Horton
Menu

Re: Improve checks for GUC recovery_target_xid

Hüseyin Demir <huseyin.d3r@gmail.com>

View thread
From: Hüseyin Demir <huseyin.d3r@gmail.com>
To: David Steele <david@pgbackrest.org>
Cc: Fujii Masao <masao.fujii@gmail.com>, Michael Paquier <michael@paquier.xyz>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-16T07:44:44Z
Lists: pgsql-hackers

Attachments

Hi,


David Steele <david@pgbackrest.org>, 6 Mar 2026 Cum, 16:01 tarihinde şunu yazdı:
>
> On 3/6/26 14:05, Fujii Masao wrote:
> > On Fri, Mar 6, 2026 at 3:15 PM Michael Paquier <michael@paquier.xyz> wrote:
> >>
> >> On Fri, Mar 06, 2026 at 12:04:00AM +0900, Fujii Masao wrote:
> >>> Thanks for the patch! It looks good to me. Barring any objections, I
> >>> will commit it.
> >>
> >> Thanks.
> >
> > I've pushed the patch. Thanks!
>
> Thank you and great idea on ALTER SYSTEM. I've been hesitant to add more
> tests in this area because they are so expensive but now I feel much
> better about it. But that's the last for this CF since there is more
> important stuff to be done.
>
> Regards,
> -David

I tried to create tests with the ALTER SYSTEM approach to validate the GUC.

You can review it if it's the correct approach or not. We can create a
new CF record if required for the patch.

Regards.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve tests for recovery_target_timeline GUC.

  2. Improve validation of recovery_target_xid GUC values.