guc: make dereference style consistent in check_backtrace_functions
zhanghu <kongbaik228@gmail.com>
From: zhanghu <kongbaik228@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Date: 2026-02-26T07:03:23Z
Lists: pgsql-hackers
Attachments
- v1-0001-guc-make-dereference-style-consistent-in-check_ba.patch (application/octet-stream) patch v1-0001
Hi, In check_backtrace_functions(), most accesses to the input string follow the pattern (*newval)[i]. However, the empty-string check is currently written as: if (*newval[0] == '\0') While functionally correct due to how the compiler handles the address-of-address context here, this form is semantically misleading. It relies on implicit operator precedence rather than explicit intent. The attached patch rewrites it as: if ((*newval)[0] == '\0') This change ensures semantic clarity and maintains a consistent dereferencing style throughout the function. No functional changes are introduced. Regards, Zhang Hu
Commits
-
Fix dereference in a couple of GUC check hooks
- 5f2350a043db 19 (unreleased) landed