Re: primary_conninfo missing from pg_stat_wal_receiver

Michael Paquier <michael.paquier@gmail.com>

From: Michael Paquier <michael.paquier@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Fujii Masao <masao.fujii@gmail.com>, Stephen Frost <sfrost@snowman.net>, Tatsuo Ishii <ishii@postgresql.org>, Vik Fearing <vik@2ndquadrant.fr>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2016-06-29T21:55:20Z
Lists: pgsql-hackers
On Thu, Jun 30, 2016 at 6:47 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> There was also that (old) thread about making the recovery.conf parameters
>> be general GUCs. I don't actually remember the consensus there, but diong
>> that would certainly change how it's handled as well.
>
> It strikes me that keeping a password embedded in the conninfo from being
> exposed might be quite a bit harder/riskier if it became a GUC.  Something
> to keep in mind if we ever try to make that change ...

Exposing it in memory for a long time is an issue even if we have a
new GUC-flag to obfuscate the value in some cases..
-- 
Michael


Commits

  1. Add conninfo to pg_stat_wal_receiver

  2. Only show pg_stat_replication details to superusers