Re: Still another race condition in recovery TAP tests
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>, Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-10-16T23:35:13Z
Lists: pgsql-hackers
On Tue, Oct 17, 2017 at 5:01 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Fri, Oct 6, 2017 at 5:57 AM, Craig Ringer <craig@2ndquadrant.com> wrote: >>> Fewer people will test as we grow the list of modules they must first install. >> At worst, all we have to do is provide a script >> that fetches them, from distro repos if possible, and failing that >> from CPAN. >> >> With cpanminus, that's pretty darn simple too. > > I think the idea that this is going to work for everybody is not very > realistic. I am not going to run some random script to install stuff > on my system in whatever manner it feels like, because when I do stuff > like that I usually end up regretting it. If it's a throw-away VM, > sure, but not otherwise. Yeah, having something which is network-dependent to run the full set of regression tests is not a good idea. I have seen users, at least in Japan, deploying Postgres on hosts that have no external connection, just a base OS image built with all packages present. Data center rules can be very strict. > We don't even have good documentation of what packages you should > install on various packaging systems to build the server, let alone > all of the additional things that may be required depending on build > options and TAP tests you might want to run. On top of that, let's not forget that we take the time to improve the modules what we already have in the code tree. Let's not forget that ;) -- Michael
Commits
-
Fix RecursiveCopy.pm to cope with disappearing files.
- e183530550dc 11.0 landed
- bd18960cb93f 10.0 landed
- 64e2b29bdea0 9.6.6 landed
-
Refactor Perl test code
- 1caef31d9e55 9.6.0 cited