Horton
Menu

Re: Support for REINDEX CONCURRENTLY

Michael Paquier <michael.paquier@gmail.com>

View thread
From: Michael Paquier <michael.paquier@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Andres Freund <andres@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>, Simon Riggs <simon@2ndquadrant.com>
Date: 2013-07-11T23:39:05Z
Lists: pgsql-hackers 
On Thu, Jul 11, 2013 at 5:11 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> I am resending the patches after Fujii-san noticed a bug allowing to
> even drop valid toast indexes with the latest code... While looking at
> that, I found a couple of other bugs:
> - two bugs, now fixed, with the code path added in tablecmds.c to
> allow the manual drop of invalid toast indexes:
> -- Even a user having no permission on the parent toast table could
> drop an invalid toast index
> -- A lock on the parent toast relation was not taken as it is the case
> for all the indexes dropped with DROP INDEX
> - Trying to reindex concurrently a mapped catalog leads to an error.
> As they have no relfilenode, I think it makes sense to block reindex
> concurrently in this case, so I modified the core patch in this sense.
This patch status has been changed to returned with feedback.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Background worker processes

  2. Fix assorted bugs in CREATE/DROP INDEX CONCURRENTLY.

  3. Work around unportable behavior of malloc(0) and realloc(NULL, 0).

  4. Properly set relpersistence for fake relcache entries.