Horton

Re: Further simplification of c.h's #include section

Michael Paquier <michael.paquier@gmail.com>

View thread View on postgr.es
From: Michael Paquier <michael.paquier@gmail.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-11-16T06:14:45Z
Lists: pgsql-hackers

Attachments

On Thu, Nov 16, 2017 at 2:23 PM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
> I do get some warnings:
>
> (ClCompile target) ->
>   src/test/modules/test_session_hooks/test_session_hooks.c(112): warning
> C4113: 'void (__cdecl *)()' differs in parameter lists from
> 'session_start_hook_type' [test_session_hooks.vcxproj]
>   src/test/modules/test_session_hooks/test_session_hooks.c(113): warning
> C4113: 'void (__cdecl *)()' differs in parameter lists from
> 'session_end_hook_type' [test_session_hooks.vcxproj].
>
>     2 Warning(s)
>
> But I imagine that was caused by 745948422c (also get the warnings without
> your patch)

Do the warnings go away with the patch attached?
-- 
Michael

Commits

  1. Further refactoring of c.h and nearby files.

  2. Rearrange c.h to create a "compiler characteristics" section.