Re: Implementing pg_receivewal --no-sync
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kuntal Ghosh <kuntalghosh.2007@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-10-28T22:12:23Z
Lists: pgsql-hackers
Attachments
- pg_receivewal_nosync_v3.patch (application/octet-stream) patch v3
On Fri, Oct 27, 2017 at 12:03 AM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Thu, Oct 26, 2017 at 10:46 PM, Robert Haas <robertmhaas@gmail.com> wrote: >> On Wed, Oct 25, 2017 at 10:03 PM, Michael Paquier >> <michael.paquier@gmail.com> wrote: >>> This sentence is actually wrong, a feedback message is never sent with >>> the feedback message. >> >> Eh? > > "A feedback message is never sent depending on the status interval". > >> I think this looks basically fine, though I'd omit the short option >> for it. There are only so many letters in the alphabet, so let's not >> use them up for developer-convenience options. > > No objections to that. Okay. Here is an updated patch incorporating those comments. -- Michael
Commits
-
pg_receivewal: Add --no-sync option.
- 5f3971291fc2 11.0 landed