Re: Bug in ExecModifyTable function and trigger issues for foreign tables
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-15T05:48:53Z
Lists: pgsql-hackers
On Mon, May 15, 2017 at 2:04 PM, Dilip Kumar <dilipbalaut@gmail.com> wrote: > On Sun, May 14, 2017 at 9:54 PM, Dilip Kumar <dilipbalaut@gmail.com> wrote: >> After your fix, now tupleid is invalid which is expected, but seems >> like we need to do something more. As per the comments seems like it >> is expected to get the oldtuple from planSlot. But I don't see any >> code for handling that part. > > Maybe we should do something like attached patch. As a deficiency, shouldn't this try as well to improve regression test coverage for FDW triggers with inheritance trees? Those tests are in postgres_fdw. You may find other issues on the way.. -- Michael
Commits
-
Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE.
- 39f180fdd1e6 9.5.11 landed
- 06ba5309682e 9.6.7 landed
- a57aa430b613 10.2 landed
- 9a785ad57317 11.0 landed