Re: Support for REINDEX CONCURRENTLY
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Andres Freund <andres@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>, Simon Riggs <simon@2ndquadrant.com>
Date: 2013-03-17T12:24:16Z
Lists: pgsql-hackers
Attachments
- 20130317_reindexdb_concurrently.patch (application/octet-stream) patch
- 20130317_dump_only_valid_index.patch (application/octet-stream) patch
Please find attached the patches wanted: - 20130317_reindexdb_concurrently.patch, adding an option -c/--concurrently to reindexdb Note that I added an error inside reindexdb for options "-s -c" as REINDEX CONCURRENTLY does not support SYSTEM. - 20130317_dump_only_valid_index.patch, a 1-line patch that makes pg_dump not take a dump of invalid indexes. This patch can be backpatched to 9.0. On Sun, Mar 17, 2013 at 3:31 AM, Michael Paquier <michael.paquier@gmail.com>wrote: > On 2013/03/17, at 0:35, Fujii Masao <masao.fujii@gmail.com> wrote: > > > On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier > > I found pg_dump dumps even the invalid index. But pg_dump should > > ignore the invalid index? > > This problem exists even without REINDEX CONCURRENTLY patch. So we might > need to > > implement the bugfix patch separately rather than including the bugfix > > code in your patches. > > Probably the backport would be required. Thought? > Hum... Indeed, they shouldn't be included... Perhaps this is already known? > Note that there have been some recent discussions about that. This *problem* also concerned pg_upgrade. http://www.postgresql.org/message-id/20121207141236.GB4699@alvh.no-ip.org -- Michael
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Background worker processes
- da07a1e85651 9.3.0 cited
-
Fix assorted bugs in CREATE/DROP INDEX CONCURRENTLY.
- 3c84046490be 9.3.0 cited
-
Work around unportable behavior of malloc(0) and realloc(NULL, 0).
- 09ac603c36d1 9.3.0 cited
-
Properly set relpersistence for fake relcache entries.
- beb850e1d873 9.3.0 cited