Re: SQL/JSON in PostgreSQL
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Piotr Stefaniak <email@piotr-stefaniak.me>,
"obartunov@gmail.com" <obartunov@gmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>,
Teodor Sigaev <teodor@postgrespro.ru>, Alexander Korotkov <a.korotkov@postgrespro.ru>,
andrew Dunstan <andrew@dunslane.net>
Date: 2017-11-03T12:34:01Z
Lists: pgsql-hackers
On Fri, Nov 3, 2017 at 12:07 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > The patch sent previously does not directly apply on HEAD, and as far > as I can see the last patch set published on > https://www.postgresql.org/message-id/2361ae4a-66b1-c6c5-ea6a-84851a1c08b5@postgrespro.ru > has rotten. Could you send a new patch set? > > About the patch set, I had a look at the first patch which is not that > heavy, however it provides zero documentation, close to zero comments, > but adds more than 500 lines of code. I find that a bit hard to give > an opinion on, having commit messages associated to each patch would > be also nice. This way, reviewers can figure what's going out in this > mess and provide feedback. Making things incremental is welcome as > well, for example in the first patch I have a hard way finding out why > timestamps are touched to begin with. My mistake here, only the first patch adds 8,200 lines of code. This makes the lack of comments and docs even worse. -- Michael
Commits
-
SQL/JSON: support the IS JSON predicate
- 6ee30209a6f1 16.0 landed
-
SQL/JSON: add standard JSON constructor functions
- 7081ac46ace8 16.0 landed