Horton
Menu

Re: Support for REINDEX CONCURRENTLY

Michael Paquier <michael.paquier@gmail.com>

View thread
From: Michael Paquier <michael.paquier@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Andres Freund <andres@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>, Simon Riggs <simon@2ndquadrant.com>
Date: 2013-03-06T00:07:03Z
Lists: pgsql-hackers 
On Tue, Mar 5, 2013 at 11:22 PM, Fujii Masao <masao.fujii@gmail.com> wrote:

> On Tue, Mar 5, 2013 at 10:35 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
> > Thanks for the review. All your comments are addressed and updated
> patches
> > are attached.
>
> I got the compile warnings:
> tuptoaster.c:1539: warning: format '%s' expects type 'char *', but
> argument 3 has type 'Oid'
> tuptoaster.c:1539: warning: too many arguments for format
>
Fixed. Thanks for catching that.


> The patch doesn't handle the index on the materialized view correctly.
>
Hehe... I didn't know that materialized views could have indexes...
I fixed it, will send updated patch once I am done with Andres' comments.
-- 
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Background worker processes

  2. Fix assorted bugs in CREATE/DROP INDEX CONCURRENTLY.

  3. Work around unportable behavior of malloc(0) and realloc(NULL, 0).

  4. Properly set relpersistence for fake relcache entries.