Re: COPY FREEZE has no warning
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Andres Freund <andres@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2013-01-26T00:45:30Z
Lists: pgsql-hackers
On Sat, Jan 26, 2013 at 2:42 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Fri, Jan 25, 2013 at 11:59 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Bruce Momjian <bruce@momjian.us> writes: > >> On Fri, Jan 25, 2013 at 02:48:37AM +0100, Andres Freund wrote: > >>> FWIW, and I won't annoy anyone further after this email, now that its > >>> deterministic, I still think that this should be an ERROR not a > WARNING. > > > >> As the FREEZE is just an optimization, I thought NOTICE, vs WARNING or > >> ERROR was fine. If others want this changed, please reply. > > > > The previous argument about it was "if you bothered to specify FREEZE, > > you probably really want/need that behavior". So I can definitely see > > Andres' point. Perhaps WARNING would be a suitable compromise? > > I'll vote for ERROR. I don't see why this sound be a best-effort thing. > + 1. I was surprised to see COPY FREEZE failing silently when testing the feature. An ERROR would be suited. -- Michael Paquier http://michael.otacoo.com