Re: Setting pd_lower in GIN metapage
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
Amit Kapila <amit.kapila16@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-06-23T06:31:04Z
Lists: pgsql-hackers
On Fri, Jun 23, 2017 at 3:17 PM, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote: > Initially, I had naively set wal_consistency_check = all before running > make installcheck and then had to wait for a long time to confirm that WAL > generated by the gin test indeed caused consistency check failure on the > standby with the v1 patch. wal_consistency_check = gin would have saved you a lot of I/O. > But I can see Sawada-san's point that there should be some way for > developers writing code that better had gone through WAL consistency > checking facility to do it without much hassle. But then again, it may > not be that frequent to need that. Yeah, I have my own set of generic scripts for that. There could be a set of modules out of the main check-world, the risk that those finish rotting is high though... -- Michael
Commits
-
Flag index metapages as standard-format in xlog.c calls.
- 4c11d2c559e7 11.0 landed
-
Set the metapage's pd_lower correctly in brin, gin, and spgist indexes.
- 81e334ce4e6d 11.0 landed