Re: logical replication and PANIC during shutdown checkpoint in publisher
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>,
Andres Freund <andres@anarazel.de>, Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-05-26T18:16:19Z
Lists: pgsql-hackers
On Sat, May 6, 2017 at 6:40 AM, Michael Paquier <michael.paquier@gmail.com> wrote: > Agreed. Just adding an ERROR message in XLogInsert() is not going to > help much as this leads also to PANIC for critical sections :( > So a patch really needs to be a no-op for all WAL-related operations > within the WAL sender, and that will be quite invasive I am afraid. > >> I will move the open item to "Older Bugs" now, because the user >> experience regression, so to speak, in version 10 has been addressed. >> (This could be a backpatching candidate, but I am not planning on it for >> next week's releases in any case.) > > No issues with all that. So, now that the last round of minor releases has happened and that some dust has settled on this patch, shouldn't there be a backpatch? If yes, do you need patches for all branches? This problems goes down to 9.2 anyway as BASE_BACKUP can generate end-of-backup records. -- Michael
Commits
-
Prevent possibility of panics during shutdown checkpoint.
- 862204aaceb1 9.6.4 landed
- 50581f2e74fa 9.5.8 landed
- 1cdc0ab9c180 9.4.13 landed
- c6c333436491 10.0 landed
-
Revert "Prevent panic during shutdown checkpoint"
- 703f148e98ec 10.0 landed
-
Prevent panic during shutdown checkpoint
- 086221cf6b17 10.0 cited