Detection of IPC::Run presence in SSL TAP tests

Michael Paquier <michael.paquier@gmail.com>

From: Michael Paquier <michael.paquier@gmail.com>
To: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2017-06-13T07:49:41Z
Lists: pgsql-hackers
Hi all,

001_ssltests.pl in src/test/ssl/ includes the following to skip all
tests should IPC::Run be not available:
# Like TestLib.pm, we use IPC::Run
BEGIN
{
        eval {
                require IPC::Run;
                import IPC::Run qw(run start);
                1;
        } or do
        {
                plan skip_all => "IPC::Run not available";
          }
}
In all the other tests or modules we don't bother about such a thing
as prove_check only works if --enable-tap-test is used, and we get a
hard failure anyway if trying to run the TAP tests with the configure
switch but without IPC::Run installed. Heikki, this looks like
unnecessary crafting to me, no? prove_check being enforced in
Makefile.global already gives enough guarantee.

Thanks,
-- 
Michael


Commits

  1. Make configure check for IPC::Run when --enable-tap-tests is specified.