Horton

Re: Supporting TAP tests with MSVC and Windows

Michael Paquier <michael.paquier@gmail.com>

View thread View on postgr.es
From: Michael Paquier <michael.paquier@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Noah Misch <noah@leadboat.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2015-07-29T23:50:19Z
Lists: pgsql-hackers 
On Thu, Jul 30, 2015 at 1:37 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> On 07/29/2015 10:13 AM, Michael Paquier wrote:
>>
>> On Sat, Jul 25, 2015 at 10:54 PM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>>
>>> An updated patch is attached.
>>
>>
>> Attached is v9, that fixes conflicts with 01f6bb4 and recent commits
>> that added TAP tests in pg_basebackup series.
>
>
> Thanks, committed with some more tweaking. Peter just added a slurp_file()
> function to TestLib.pm, so I used that to replace the call to 'cat' instead
> of my previous snippet. I also fixed the issue in the pg_basebackup test,
> that LSN is not necessarily 8 characters long, slightly differently. Calling
> pg_xlogfile_name seemed a bit indirect.

Thanks!
-- 
Michael

Commits

  1. Account for IPC::Run::result() Windows behavior change.

  2. Make TAP tests work on Windows.