Re: REINDEX CONCURRENTLY 2.0
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Jim Nasby <Jim.Nasby@bluetreble.com>,
Andres Freund <andres@2ndquadrant.com>,
PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2014-11-11T04:52:22Z
Lists: pgsql-hackers
Attachments
- 20141110_reindex_concurrently_3_v4.patch (application/x-patch) patch v4
On Tue, Nov 11, 2014 at 3:24 AM, Jeff Janes <jeff.janes@gmail.com> wrote: > > On Wed, Nov 5, 2014 at 8:49 PM, Michael Paquier <michael.paquier@gmail.com> wrote: >> >> On Thu, Oct 30, 2014 at 5:19 PM, Michael Paquier >> <michael.paquier@gmail.com> wrote: >> > Updated patch is attached. >> Please find attached an updated patch with the following things changed: >> - Addition of tab completion in psql for all new commands >> - Addition of a call to WaitForLockers in index_concurrent_swap to >> ensure that there are no running transactions on the parent table >> running before exclusive locks are taken on the index and its >> concurrent entry. Previous patch versions created deadlocks because of >> that, issue spotted by the isolation tests integrated in the patch. >> - Isolation tests for reindex concurrently are re-enabled by default. >> Regards, > > > It looks like this needs another rebase, I get failures on index.c, toasting.c, indexcmds.c, and index.h Indeed. There are some conflicts created by the recent modification of index_create. Here is a rebased patch. -- Michael
Commits
-
Prevent reindex of invalid indexes on TOAST tables
- 8bca5f93547c 12.3 landed
- 61d7c7bce368 13.0 landed
-
Rework handling of invalid indexes with REINDEX CONCURRENTLY
- a6dcf9df4d91 12.0 landed
-
Split builtins.h to a new header ruleutils.h
- 7b1c2a0f2066 9.5.0 cited