Re: request patch pg_recvlogical.c, pg_receivexlog.c for nls

Michael Paquier <michael.paquier@gmail.com>

View thread

From: Michael Paquier <michael.paquier@gmail.com>

To: Ioseph Kim <pgsql-kr@postgresql.kr>

Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>

Date: 2015-12-28T13:33:23Z

Lists: pgsql-hackers

Attachments

20151228_catalog_name_fix.patch (text/x-patch) patch

On Mon, Dec 28, 2015 at 5:07 PM, Ioseph Kim <pgsql-kr@postgresql.kr> wrote:
> Hello,
>
> at PostgreSQL version 9.5rc1,
> at line 934 in pg_recvlogical.c
>
>         set_pglocale_pgservice(argv[0],PG_TEXTDOMAIN("pg_recvlogical"));
>
> this references invalid catalog file, because pg_basebackup,
> pg_recvlogical, pg_receivexlog commands use same catalog file
> pg_basebackup.mo
>
> pg_receivexlog.c too.
>
> patch please.

Yes, you are right. Both values do not match CATALOG_NAME in nls.mk. I
guess that something like the attached is fine then... The other
binaries are fine.
-- 
Michael