Re: Renaming of pg_xlog and pg_clog
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Craig Ringer <craig.ringer@2ndquadrant.com>,
Jim Nasby <Jim.Nasby@bluetreble.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
Andres Freund <andres@anarazel.de>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2016-09-30T05:45:29Z
Lists: pgsql-hackers
Attachments
- 0001-Rename-pg_xlog-to-pg_wal.patch (text/x-diff) patch 0001
- 0002-Rename-pg_clog-to-pg_transaction.patch (text/x-diff) patch 0002
On Fri, Sep 30, 2016 at 1:32 PM, Thomas Munro <thomas.munro@enterprisedb.com> wrote: > +1 for pg_xlog -> pg_wal. This is clearly the winner here and... > Of the existing suggestions, would like to add my vote for the > following renames, matching pg_multixact: > > pg_clog -> pg_xact > pg_subtrans -> pg_subxact > > If longer names are on the table, I would consider expanding all three of those: > > pg_clog -> pg_transaction This one sounds like the consensus by what I am reading upthread. > pg_subtrans -> pg_subtransaction > pg_multixact -> pg_multitransaction > > They sound eminently non-deletable. Well the original complain was that users tend to remove the entries that include *log. I am not sure if it is worth worrying about doing that much. Anyway, those patches have rotten because of the commits of yesterday for initdb and basebackup.c (stuff I wrote and/or reviewed actually). So attached is a rebased set. 0001 does the work for pg_wal, 0002 for pg_transaction. As there have been no reviews at code level, I am moving that to the next CF. -- Michael
Commits
-
Rename "pg_clog" directory to "pg_xact".
- 88e66d193fba 10.0 landed
-
Improve error reporting in pg_upgrade's file copying/linking/rewriting.
- f002ed2b8e45 10.0 cited