Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Vladimir Rusinov <vrusinov@google.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2016-12-27T03:15:44Z
Lists: pgsql-hackers
On Thu, Dec 15, 2016 at 8:51 AM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Thu, Dec 15, 2016 at 1:20 AM, Vladimir Rusinov <vrusinov@google.com> wrote: >>> Personally, I think this is not important, but if you want to do it, I'd >>> follow the suggestion in the thread to rename all functions and leave >>> the old names as aliases or wrappers of some kind. >> >> I think I agree with Michael Paquier: "Better to do breakages in a single >> release rather than spreading them across releases.". >> There's going to be a lot of broken scripts following pg_xlog rename, so I >> think it makes sense to just drop functions as well. > > For consistency that makes sense in my view. But I won't be too noisy > as well if people think that we should keep aliases for compatibility. Actually, I am changing my mind on this bit, following Peter's opinion. Maintaining aliases of the past functions is a no-brainer, and it has no cost in terms of maintenance. That will save much pain to many monitoring scripts as well. -- Michael
Commits
-
Remove all references to "xlog" from SQL-callable functions in pg_proc.
- 806091c96f9b 10.0 landed
-
Replace pg_shadow and pg_group by new role-capable catalogs pg_authid
- 7762619e9527 8.1.0 cited