Horton

Re: Removing #include "postgres.h" from a couple of headers

Michael Paquier <michael.paquier@gmail.com>

View thread View on postgr.es
From: Michael Paquier <michael.paquier@gmail.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-08T08:58:06Z
Lists: pgsql-hackers 
On Wed, Mar 8, 2017 at 5:55 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> Over in another thread it was pointed out that a patch I submitted
> broke a project rule by including "postgres.h" in a header.  Here is a
> patch to remove it from dsa.h where I made the same mistake, and also
> a case I found in bufmask.h by grepping.
>
> There are also instances in regcustom.h and snowball's header.h -- are
> those special cases?

--- a/src/include/access/bufmask.h
+++ b/src/include/access/bufmask.h
@@ -17,7 +17,6 @@
 #ifndef BUFMASK_H
 #define BUFMASK_H

-#include "postgres.h"
 #include "storage/block.h"
 #include "storage/bufmgr.h"
Oops. This really escaped me...
-- 
Michael

Commits

  1. Fix inclusions of c.h from .h files.

  2. Fix inclusions of postgres_fe.h from .h files.

  3. Bring plpgsql into line with header inclusion policy.

  4. Document intentional violations of header inclusion policy.

  5. Remove inclusion of postgres.h from a few header files.