Re: BUG #14876: Segmentation fault with JSONB column used in store proc that gets used by view and later altered
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: samuel.horwitz@gmail.com, PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Date: 2017-10-28T03:14:56Z
Lists: pgsql-bugs
On Fri, Oct 27, 2017 at 6:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paquier@gmail.com> writes: >> Sorry for coming up late in the game. I can see that you have pushed a >> patch as d5b760e, but back-paddled a bit on d76886c. After some >> analysis of things around, I think that you got it right. One comment >> I have first though is that you could have used forboth as there is no >> point to go through the target list entries once there are no more >> aliases. Or target list entries marked as resjunk do not have an >> expended reference name? > > Right, there's no entry in the outer RTE for resjunk columns. > > (In practice, resjunk entries are at the end of the tlist so that it > wouldn't really matter, but I try to keep code from assuming that.) OK, thanks for confirming. Yes the current logic is better this way. -- Michael
Commits
-
Fix crash when columns have been added to the end of a view.
- d5b760ecb5e1 11.0 landed
- ddde3b4f3e88 10.1 landed
- acd3287e437e 9.5.10 landed
- 9d15b8b36a91 9.3.20 landed
- 80e79718d0ea 9.2.24 landed
- 7e5e8b36d478 9.6.6 landed
- 66104119e1fb 9.4.15 landed