Horton
Menu

Re: Proposal for changes to recovery.conf API

Michael Paquier <michael.paquier@gmail.com>

View thread
From: Michael Paquier <michael.paquier@gmail.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Josh Berkus <josh@agliodbs.com>, Magnus Hagander <magnus@hagander.net>, Andres Freund <andres@anarazel.de>, Abhijit Menon-Sen <ams@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-01-11T13:02:53Z
Lists: pgsql-hackers 
On Wed, Jan 11, 2017 at 7:36 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> The specification of the recovery target parameters should be different, IMHO.
>
> If the user is performing a recovery and the target of the recovery is
> incorrectly specified then it is clear that the recovery cannot
> continue with an imprecisely specified target. So in my understanding
> we would need to either
>
> 1) issue a WARNING and pause recovery
>
> 2) issue an ERROR (which becomes FATAL in Startup process) and exit recovery
>
> My view would be 2) is the most useful, though I am willing to hear
> other points and/or go with majority view

I agree with that. 2) is more consistent with what is in core now.
-- 
Michael