Horton

Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

Michael Paquier <michael.paquier@gmail.com>

View thread View on postgr.es
From: Michael Paquier <michael.paquier@gmail.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Christoph Berg <christoph.berg@credativ.de>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-12-21T13:27:19Z
Lists: pgsql-hackers 
On Thu, Dec 21, 2017 at 10:13 PM, Andrew Dunstan
<andrew.dunstan@2ndquadrant.com> wrote:
> Looks reasonable. Regarding the change to TestLib.pm, we should make
> sure that the tests have unique names. There is a small amount of
> duplication currently:
>
>     ./src/bin/pg_dump/t/001_basic.pl
>     ./src/bin/pg_rewind/t/001_basic.pl
>     ./src/test/modules/commit_ts/t/001_base.pl
>     ./src/test/modules/test_pg_dump/t/001_base.pl

Why does the uniqueness of application_name set in the TAP test suite
matter? Each instance of Postgres is self-contained into its own Unix
domain path and port.
-- 
Michael

Commits

  1. Avoid putting build-location-dependent strings into generated files.