Horton
Menu

Re: Support for REINDEX CONCURRENTLY

Michael Paquier <michael.paquier@gmail.com>

View thread
From: Michael Paquier <michael.paquier@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Andres Freund <andres@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>, Simon Riggs <simon@2ndquadrant.com>
Date: 2013-07-03T18:38:04Z
Lists: pgsql-hackers 
On Thu, Jul 4, 2013 at 3:26 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Thu, Jul 4, 2013 at 2:41 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Thu, Jul 4, 2013 at 2:36 AM, Andres Freund <andres@2ndquadrant.com> wrote:
>>> On 2013-07-04 02:32:32 +0900, Michael Paquier wrote:
>>>> > Wouldn't it make more sense to fetch the toast index oid in the query
>>>> > ontop instead of making a query for every relation?
>>
>> +1
>> I changed the query that way. Updated version of the patch attached.
>>
>> Also I updated the rules.out because Michael changed the system_views.sql.
>> Otherwise, the regression test would fail.
>>
>> Will commit this patch.
>
> Committed. So, let's get to REINDEX CONCURRENTLY patch!
Thanks for the hard work! I'll work on something based on MVCC
catalogs, so at least lock will be lowered at swap phase and isolation
tests will be added.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Background worker processes

  2. Fix assorted bugs in CREATE/DROP INDEX CONCURRENTLY.

  3. Work around unportable behavior of malloc(0) and realloc(NULL, 0).

  4. Properly set relpersistence for fake relcache entries.