Horton

Re: [BUGS] BUG #13741: vacuumdb does not accept valid password

Michael Paquier <michael.paquier@gmail.com>

View thread View on postgr.es
From: Michael Paquier <michael.paquier@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Haribabu Kommi <kommi.haribabu@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, brown@fastmail.com, "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2015-12-24T00:21:46Z
Lists: pgsql-bugs, pgsql-hackers 
On Thu, Dec 24, 2015 at 1:55 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Tom Lane wrote:
>
>> Sorry for having lost track of this.  I think if we're going to do this,
>> we should do it now not later, because it essentially reverts the
>> connectDatabase() API change made in 83dec5a71 in favor of a different API
>> change with the same purpose.  Now, that doesn't matter if no third-party
>> code is using connectDatabase(), but I have a suspicion that there
>> probably is some.  Any such users will not thank us for whacking
>> connectDatabase's API around in 9.5 and then whacking it around
>> differently in 9.6.
>>
>> In short, I think we should apply this now and back-patch into 9.5,
>> like the prior patch, even though we're post-RC1.  The reduction in
>> cross-version API churn is worth it.
>>
>> If no objections, I'll go do that shortly.
>
> No objection here.

Thanks for taking care of that!
-- 
Michael

Commits

  1. vacuumdb: don't prompt for passwords over and over