Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
Alvaro Herrera <alvherre@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-08-30T22:16:59Z
Lists: pgsql-hackers
On Tue, Aug 29, 2017 at 11:26 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paquier@gmail.com> writes: >> I don't like breaking the abstraction of pg_log() with the existing >> flags with some kind of pg_debug() layer. The set of APIs present now >> in pg_rewind for logging is nice to have, and I think that those debug >> messages should be translated. So what about the attached? > > Your point about INT64_FORMAT not necessarily working with fprintf > is an outstanding reason not to keep it like it is. I've not reviewed > this patch in detail but I think this is basically the way to fix it. So, perhaps it would be better to fix that before the next point release? -- Michael
Commits
-
Fix translatable string
- 8d5ec8ee3809 9.5.10 landed
- a1af1e7cfaef 10.0 landed
- bd75335a83bf 9.6.6 landed
- 863d75439e87 11.0 landed
-
pg_rewind: Fix some problems when copying files >2GB.
- 73fbf3d3d0a5 9.6.4 cited