Horton
Menu

Re: BUG #14243: pg_basebackup failes by a STATUS_DELETE_PENDING file

Michael Paquier <michael.paquier@gmail.com>

View thread
From: Michael Paquier <michael.paquier@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, TAKATSUKA Haruka <harukat@sraoss.co.jp>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Bugs <pgsql-bugs@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-01-01T09:53:52Z
Lists: pgsql-bugs 
On Sat, Dec 31, 2016 at 9:27 PM, Magnus Hagander <magnus@hagander.net> wrote:
> So, we're still with zero ability to reproduce this problem enough to know
> if it's fixed, or if other issues are caused.
>
> I'm thinking maybe we should push this patch to master, to at least get a
> largeish number of runs with it on a bunch of different platforms. No
> backpatching until we've seen it run there for some time to feel more
> confident about it.
>
> Thoughts?

Yeah, I kind of agree with that. Not reacting with an ENOENT on
win32's stat() if ERROR_DELETE_PENDING is found is definitely wrong,
as is not doing the mapping in win32error.c.
-- 
Michael