Horton

Re: BUG #17777: An assert failed in nodeWindowAgg.c

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, xinwen@stu.scu.edu.cn, pgsql-bugs@lists.postgresql.org
Date: 2023-02-13T05:29:46Z
Lists: pgsql-bugs 
On Mon, 13 Feb 2023 at 13:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Code looks good now, but the comment still claims this is only
> important in the FILTER clause.  I'd rewrite the whole thing
> perhaps:
>
>     * We also don't risk using moving aggregates when there are subplans
>     * in the arguments or FILTER clause.  This is partly because
>     * contain_volatile_functions() doesn't look inside subplans; but
>     * there are other reasons why a subplan's output might be volatile.
>     * For example, syncscan mode can render the results nonrepeatable.

That seems better, so I pushed it with that. Thanks.

David

Commits

  1. Disable WindowAgg inverse transitions when subplans are present