Horton

Re: BUG #17777: An assert failed in nodeWindowAgg.c

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, xinwen@stu.scu.edu.cn, pgsql-bugs@lists.postgresql.org
Date: 2023-02-13T00:31:54Z
Lists: pgsql-bugs

Attachments

On Mon, 13 Feb 2023 at 05:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Why is it okay to check only the filter, and not the rest of the
> WindowFunc's subexpressions?  The arguments we've just run through
> seem to apply to a subplan in the direct or aggregated arguments
> as well.

Good point.  I had just been thinking in terms of the reported bug to
make sure we inverse transition the same rows we transition. We also
need to make sure the transition value matches in both transition
directions.

I've adjusted the patch accordingly.

David

Commits

  1. Disable WindowAgg inverse transitions when subplans are present