Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Nikolay Samokhvalov <samokhvalov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-11-06T00:23:26Z
Lists: pgsql-hackers
Attachments
- explain_buffers_by_default.patch (text/plain) patch
On Wed, 6 Nov 2024 at 12:33, David G. Johnston <david.g.johnston@gmail.com> wrote: > The main premise here is that explain should include buffers by default, and to do so we are willing to inconvenience testers who do not want buffer data in their test plans to have to modify their tests to explicitly exclude buffers. We'll have to eat our own dog food here and go and add "buffers off" throughout our code base to make this happen. I personally feel that we should accept a patch that does so. The benefits to the many outweigh the one-time inconveniencing of the few. Especially if limited to explain analyze. I'm not against analyze = on turning buffers on by default. However, I think it would be quite painful to fix the tests if it were on without analyze. I tried it to see just how extensive the changes would need to be. It's not too bad. partition_prune.sql is the worst hit. 23 files changed, 171 insertions(+), 166 deletions(-) David
Commits
-
Fix further fallout from EXPLAIN ANALYZE BUFFERS change
- 89988ac5891b 18.0 landed
-
Add missing BUFFERS OFF in regression tests, take 2
- 9df2a4b9316f 18.0 landed
-
Add missing BUFFERS OFF in select_into regression tests
- 9fa1aaa6525a 18.0 landed
-
Enable BUFFERS with EXPLAIN ANALYZE by default
- c2a4078ebad7 18.0 landed