Horton

Re: Protecting allocator headers with Valgrind

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Noah Misch <noah@leadboat.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Richard Guo <guofenglinux@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-04-16T05:29:34Z
Lists: pgsql-hackers 
On Sun, 16 Apr 2023 at 03:26, Noah Misch <noah@leadboat.com> wrote:
> Not objecting.  I think the original Valgrind integration refrained from this
> because it would have added enough Valgrind client requests to greatly slow
> Valgrind runs.  Valgrind reduced the cost of client requests in later years,
> so this new conclusion is reasonable.

I tested that. It's not much slowdown:

time make installcheck

Unpatched: real    79m36.458s
Patched: real    81m31.589s

I forgot to mention, I pushed the patch yesterday.

David

Commits

  1. Adjust Valgrind macro usage to protect chunk headers