Horton

Re: Crash in add_paths_to_append_rel

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-10-10T03:52:05Z
Lists: pgsql-hackers 
On Mon, 9 Oct 2023 at 22:49, Richard Guo <guofenglinux@gmail.com> wrote:
> I came across a crash in add_paths_to_append_rel() with the query below.

> It was introduced by commit a8a968a8 where we referenced
> cheapest_startup_path->param_info without first checking that we have a
> valid cheapest_startup_path.

I pushed this with just minor adjustments to the comments you wrote. I
didn't feel the need to reiterate on the set_cheapest() comments.

David

Commits

  1. Fix possible crash in add_paths_to_append_rel()

  2. Consider cheap startup paths in add_paths_to_append_rel