Re: Fix a couple of typos in JIT
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Abhijit Menon-Sen <ams@toroid.org>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
Andres Freund <andres@anarazel.de>
Date: 2020-08-20T10:51:41Z
Lists: pgsql-hackers
On Thu, 20 Aug 2020 at 22:29, Abhijit Menon-Sen <ams@toroid.org> wrote: > > At 2020-08-20 22:19:49 +1200, dgrowleyml@gmail.com wrote: > > > > I was just looking over the JIT code and noticed a few comment and > > documentation typos. The attached fixes them. > > The first change does not seem to be correct: > > -That this is done at query execution time, possibly even only in cases > -where the relevant task is done a number of times, makes it JIT, > -rather than ahead-of-time (AOT). Given the way JIT compilation is used > -in PostgreSQL, the lines between interpretation, AOT and JIT are > -somewhat blurry. > +This is done at query execution time, possibly even only in cases where > +the relevant task is done a number of times, makes it JIT, rather than > +ahead-of-time (AOT). Given the way JIT compilation is used in PostgreSQL, > +the lines between interpretation, AOT and JIT are somewhat blurry. > > The original sentence may not be the most shining example of > sentence-ry, but it is correct, and removing the "That" breaks it. Oh, I see. I missed that. Perhaps it would be better changed to "The fact that this" David
Commits
-
Fix a few typos in JIT comments and README
- 6910faa38c3a 11.10 landed
- 3248633579e9 12.5 landed
- 0d7437de73b6 13.0 landed
- 8431d33079a2 14.0 landed