Horton

Re: Fixup some appendStringInfo and appendPQExpBuffer calls

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Tomas Vondra <tomas.vondra@enterprisedb.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-04T10:53:58Z
Lists: pgsql-hackers

Attachments

On Thu, 3 Jun 2021 at 16:17, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > There are quite a few other places in that file that should be using
> > DatumGetCString() instead of DatumGetPointer().
> > Should we fix those too for PG14?
>
> +1.  I'm surprised we are not getting compiler warnings.

I pushed a fix for this.

I did happen to find one other in mcv.c which dates back to 2019. I
was wondering if we should bother with that one since it's already out
there in PG13.

David

Commits

  1. Clean up some questionable usages of DatumGet* macros

  2. Standardize usages of appendStringInfo and appendPQExpBuffer