Re: Add mention of execution time memory for enable_partitionwise_* GUCs
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Dimitrios Apostolou <jimis@gmx.net>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2024-07-18T10:54:43Z
Lists: pgsql-hackers
On Thu, 18 Jul 2024 at 22:28, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> wrote: > > On Thu, Jul 18, 2024 at 3:33 PM David Rowley <dgrowleyml@gmail.com> wrote: > > hmm? please tell me what word other than "can" best describes > > something that is possible to happen but does not always happen under > > all circumstances. > > May I suggest "may"? :) [1], [2], [3]. Is this a wind-up? If it's not, I disagree that "may" is a better choice. The possibility example in your first link says "It may rain tomorrow. (possibility)", but that's something someone would only say if there was some evidence to support that, e.g. ominous clouds on the horizon at dusk, or >0% chance of precipitation on the weather forecast. Nobody is going to say that unless there's some supporting evidence. For the executor using work_mem * nparts, we've no evidence either. It's just a >0% possibility with no supporting evidence. > My point is, we need to highlight the role of work_mem. So modify both > the descriptions. I considered writing about work_mem, but felt I wanted to keep it as brief as possible and just have some words that might make someone think twice. The details in the work_mem documentation should inform the reader that work_mem is per executor node. It likely wouldn't hurt to have more documentation around which executor node types can use a work_mem, which use work_mem * hash_mem_multiplier and which use neither. We tend to not write too much about executor nodes in the documents, so I'm not proposing that for this patch. David > [1] https://www.thesaurus.com/e/grammar/can-vs-may/
Commits
-
Doc: mention executor memory usage for enable_partitionwise* GUCs
- 447e25c04915 12.20 landed
- 5eea78af2d3c 13.16 landed
- 51895d08b41a 14.13 landed
- 27146e79bf03 15.8 landed
- a459e583e06b 16.4 landed
- 3256722d7b7f 17.0 landed
- 057ee9183c21 18.0 landed