Re: Some ExecSeqScan optimizations

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>

To: Amit Langote <amitlangote09@gmail.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Junwang Zhao <zhjwpku@gmail.com>

Date: 2025-01-10T04:06:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor ExecScan() to allow inlining of its core logic
- fb9f955025f7 18.0 landed

Attachments

minor_fixes.txt (text/plain)

On Fri, 10 Jan 2025 at 02:46, Amit Langote <amitlangote09@gmail.com> wrote:
>
> On Mon, Jan 6, 2025 at 10:18 PM David Rowley <dgrowleyml@gmail.com> wrote:
> > I've attached my workings of what I was messing around with. It seems
> > to perform about the same as your version. I think maybe we'd need
> > some sort of execScan.h instead of where I've stuffed the functions
> > in.
>
> I've done that in the attached v2.

I think 0001 looks ok, aside from what the attached fixes. (at least
one is my mistake)

Did you test the performance of 0002? I didn't look at it hard enough
to understand what you've done. I can look if performance tests show
that it might be worthwhile considering.

David