Horton

Thread

Commits

  1. Fix incorrect comments for Memoize struct

  1. weird comments in Memoize nodes

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2022-05-16T16:21:09Z

    Consider:

typedef struct Memoize
{
     Plan        plan;

     int         numKeys;        /* size of the two arrays below */

     Oid        *hashOperators;  /* hash operators for each key */
     Oid        *collations;     /* cache keys */
     List       *param_exprs;    /* exprs containing parameters */
     ...

I think the comment "cache keys" is weird here.  Maybe it was copied from

typedef struct MemoizePath
{
     Path        path;
     Path       *subpath;        /* outerpath to cache tuples from */
     List       *hash_operators; /* hash operators for each key */
     List       *param_exprs;    /* cache keys */
     ...

but it's attached to a different field there.

Is this a mistake, or could this be clarified?

  2. Re: weird comments in Memoize nodes

    David Rowley <dgrowleyml@gmail.com> — 2022-05-16T20:02:37Z

    On Tue, 17 May 2022 at 04:21, Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
>      Oid        *collations;     /* cache keys */

> Is this a mistake, or could this be clarified?

Yeah, must be a copy-pasto.  I'll fix it with the attached after beta1
is tagged.

David

  3. Re: weird comments in Memoize nodes

    David Rowley <dgrowleyml@gmail.com> — 2022-05-19T05:16:05Z

    On Tue, 17 May 2022 at 08:02, David Rowley <dgrowleyml@gmail.com> wrote:
> Yeah, must be a copy-pasto.  I'll fix it with the attached after beta1
> is tagged.

Pushed.

David