Re: Something seems weird inside tts_virtual_copyslot()

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-07T08:29:41Z
Lists: pgsql-hackers
On Fri, 1 Dec 2023 at 14:30, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Fri, 1 Dec 2023 at 13:14, Andres Freund <andres@anarazel.de> wrote:
> > So I think adding an assert to ExecCopySlot(), perhaps with a comment saying
> > that the restriction could be lifted with a bit of work, would be fine.
>
> How about the attached?  I wrote the comment you mentioned and also
> removed the Assert from tts_virtual_copyslot().

I looked over this again and didn't see any issues, so pushed the patch.

Thanks for helping with this.

David



Commits

  1. Verify that attribute counts match in ExecCopySlot