Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Vik Fearing <vik@postgresfriends.org>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Erwin Brandstetter <brsaweda@gmail.com>
Date: 2022-10-18T00:05:23Z
Lists: pgsql-hackers
Thanks for having a look at this. On Fri, 14 Oct 2022 at 10:52, Zhihong Yu <zyu@yugabyte.com> wrote: > + req->frameOptions = (FRAMEOPTION_ROWS | > + FRAMEOPTION_START_UNBOUNDED_PRECEDING | > + FRAMEOPTION_END_CURRENT_ROW); > > The bit combination appears multiple times in the patch. > Maybe define the combination as a constant in supportnodes.h and reference it in the code. I don't believe supportnodes.h has any business having any code that's related to actual implementations of the support request type. If we were to have such a definition then I think it would belong in windowfuncs.c. I'd rather see each implementation of the support request spell out exactly what they mean, which is what the patch does already. David
Commits
-
Allow window functions to adjust their frameOptions
- ed1a88ddaccf 16.0 landed