Horton

Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-18T02:19:06Z
Lists: pgsql-hackers 
On Mon, 18 Aug 2025 at 13:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > I wondered about that and thought that there might be an above zero
> > chance that someone would want HASH_DEBUG without USE_ASSERT_CHECKING.
> > I don't really know if that person exists. It certainly isn't me.
>
> Yeah, it's really quite unclear what the existing HASH_DEBUG printout
> is good for.  At least in our usage, it doesn't tell you anything
> you can't discover from static code analysis.  I'm +1 for just
> dropping it altogether.

I'm starting to lean more towards that myself. I had mostly just been
motivated to finding a way to prevent it from existing in a broken
state again.

HASH_STATISTICS I can imagine is more useful as that information isn't
otherwise recorded anywhere.

David

Commits

  1. Remove HASH_DEBUG output from dynahash.c

  2. Use elog(DEBUG4) for dynahash.c statistics output

  3. Fix invalid format string in HASH_DEBUG code

  4. Fix failing -D HASH_STATISTICS builds

  5. Refactor initial hash lookup in dynahash.c

  6. Remove large fill factor support from dynahash.c.

  7. Remove broken and useless entry-count printing in HASH_DEBUG code.

  8. Partition the freelist for shared dynahash tables.