Re: [PATCH] Documentation: Fix minor grammatical and formatting issues
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Noboru Saito <noborusai@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-04-21T04:03:09Z
Lists: pgsql-hackers
On Mon, 21 Apr 2025 at 15:06, Noboru Saito <noborusai@gmail.com> wrote: > 1. Remove unnecessary blank lines (blankline.diff) Looks good. > 2. Fix repeated "to to" in several command reference files (toto.diff) - Specifies the name of the database to connect to to discover which + Specifies the name of the database to connect to discover which What's there is acceptable English, but it's maybe confusing to a non-native speaker and might be worth adjusting so it's easier to parse. "connect to to discover" is just short for "connect to in order to discover". If it's confusing, maybe we could rephrase the whole sentence. How about: "When the <option>-a</option>/<option>--all</option> is used, connect to this database to gather the list of databases to vacuum." > 3. Fix period instead of comma in enumeration (comma.diff) Looks good. > 4. Standardize inline tags in libpq documentation (tagmiss.diff) Looks good. > 5. Remove redundant "that that" constructions (thatthat.diff) I don't see anything wrong here. [1] does a better job of explaining #5 than I can. David [1] https://english.stackexchange.com/questions/492349/is-my-use-of-that-that-in-this-sentence-gramaticaly-correct
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Doc: reword text explaining the --maintenance-db option
- c5ba351864d6 13.21 landed
- 442c992e9586 14.18 landed
- 9a5da12aba42 15.13 landed
- d2b065084a4a 16.9 landed
- f04b11454d5d 17.5 landed
- 0b06459f3c0a 18.0 landed
-
Doc: various fixups
- 5e6f9a9c4e7e 18.0 landed
-
Doc: fix incorrect punctuation
- 12bf43410aba 17.5 landed
- d010cc6ccacf 18.0 landed