Re: Error when using array_agg with filter where clause in pg16 and pg17

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kaimeh <kkaimeh@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2025-04-09T02:55:33Z
Lists: pgsql-bugs
On Wed, 9 Apr 2025 at 14:36, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> David Rowley <dgrowleyml@gmail.com> writes:
> > I'm not following why my in method if the planner chooses a poor plan
> > is any different from the planner choosing a poor plan for anything
> > else because the stats or costs aren't a good reflection of reality.
>
> Well, we hope we'll usually pick the right thing.  But upthread
> you were complaining that any change might be a regression, or
> at least that's how I read it.

I'm mostly concerned about just a blanket disabling of the presorted
optimisation when the Aggref has a FILTER. I think that's what you
proposed at one point. I'm more happy to go with your first proposal
to try and figure out if the args are safe to sort before filtering.

David



Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix issue with ORDER BY / DISTINCT aggregates and FILTER

  2. Improve performance of ORDER BY / DISTINCT aggregates