Re: [PATCH] Documentation: Fix minor grammatical and formatting issues
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Noboru Saito <noborusai@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-04-22T00:07:55Z
Lists: pgsql-hackers
Attachments
- app-clusterdb.html (text/html)
- doc_maintenance-db_improvements.patch (application/octet-stream) patch
On Tue, 22 Apr 2025 at 08:53, Noboru Saito <noborusai@gmail.com> wrote: > Regarding "to to" and "that that", I agree that they might be > technically acceptable. > However, I personally find them a bit harder to parse and they > increase the chance of misreading for me. > Your suggested alternative for "to to" is much clearer! > > Ultimately, if leaving them as-is is perfectly fine, I'm happy to > defer to your judgment. > But I would certainly welcome the improvement if you decide to revise > those phrases. I've pushed all your suggestions aside from the toto.diff and thatthat.diff. I noticed your tagmiss.diff was moving things in the wrong direction. After looking at usages of <symbol>, we seem to use that for preprocessor #defines. The following shows we're more consistent with using <symbol> for these: $ git grep -F "<symbol>BLCKSZ</symbol>" | wc -l 26 $ git grep -F "<literal>BLCKSZ</literal>" | wc -l 1 There's probably a bigger project there for anyone who feels strongly enough about this and wants to harvest our list of #defines and check how we reference those in the docs. I resisted fixing that one as it's probably the tip of the iceberg. Please see the attached patch which aims to improve the "to to" instances (also a compiled .html for ease of review). Does anyone have any opinion on the wording I'm proposing in the attached? David
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Doc: reword text explaining the --maintenance-db option
- c5ba351864d6 13.21 landed
- 442c992e9586 14.18 landed
- 9a5da12aba42 15.13 landed
- d2b065084a4a 16.9 landed
- f04b11454d5d 17.5 landed
- 0b06459f3c0a 18.0 landed
-
Doc: various fixups
- 5e6f9a9c4e7e 18.0 landed
-
Doc: fix incorrect punctuation
- 12bf43410aba 17.5 landed
- d010cc6ccacf 18.0 landed