Horton
Menu

Re: [PATCH] Add tests for Bitmapset

David Rowley <dgrowleyml@gmail.com>

View thread
From: David Rowley <dgrowleyml@gmail.com>
To: Greg Burd <greg@burd.me>
Cc: Ranier Vilela <ranier.vf@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-09T01:57:41Z
Lists: pgsql-hackers 
On Thu, 9 Oct 2025 at 07:48, Greg Burd <greg@burd.me> wrote:
>                      bms = bms_del_member(bms, member);
> +                    num_members--;
> +                    memmove(members + pos, members + pos + 1,
> +                                     (num_members - pos) * sizeof(int));

I don't think there's any need to maintain the order of that members
array, so couldn't you just do this?:

bms = bms_del_member(bms, member);
members[pos] = members[--num_members];

David

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Minor fixes for test_bitmapset.c

  2. test_bitmapset: Improve random function

  3. Add mem_exceeded_count column to pg_stat_replication_slots.

  4. Tidy-up unneeded NULL parameter checks from SQL function

  5. Remove check for NULL in STRICT function

  6. Fixes for comments in test_bitmapset

  7. Minor fixups of test_bitmapset.c

  8. test_bitmapset: Simplify code of the module

  9. test_bitmapset: Expand more the test coverage

  10. Fix compiler warnings in test_bitmapset

  11. Add a test module for Bitmapset