Horton

Re: Improve heapgetpage() performance, overhead from serializable

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Melanie Plageman <melanieplageman@gmail.com>, John Naylor <johncnaylorls@gmail.com>, Zhang Mingli <zmlpostgres@gmail.com>, pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Date: 2024-04-08T04:18:21Z
Lists: pgsql-hackers 
On Mon, 8 Apr 2024 at 16:08, Andres Freund <andres@anarazel.de> wrote:
>
> On 2024-04-08 15:43:12 +1200, David Rowley wrote:
> > I understand wanting to avoid the long name.  I'd rather stay clear of
> > "visible", but don't feel as strongly about this as it's static.
>
> I think visible would be ok, the serialization checks are IMO about
> visibility too. But if you'd prefer I'd also be ok with something like
> page_collect_tuples()?

That's ok for me.

David

Commits

  1. Remove references to old function name

  2. Reduce branches in heapgetpage()'s per-tuple loop