Re: Fix typos and inconsistencies for v16

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Date: 2023-04-20T22:49:42Z
Lists: pgsql-hackers
On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin <exclusion@gmail.com> wrote:
> please look at the similar list for v15+ (596b5af1d..HEAD).

I've now pushed most of these but didn't include the following ones:

> 3. BufFileOpenShared -> BufFileOpenFileSet // see dcac5e7ac

Maybe I need to spend longer, but I just didn't believe the command
that claimed that "BufFiles opened using BufFileOpenFileSet() are
read-only by definition". Looking at the code for that, it seems to
depend on if O_RDONLY is included in the mode flags.

> 19. multidimensional-aware -> multidimension-aware // sync with gistbuild.c

I didn't change this as I didn't think it was an improvement.  I'd
probably have written "multidimensionally aware", but I didn't feel
strongly enough to want to change it.

David



Commits

  1. Fix typo with wait event for SLRU buffer of commit timestamps

  2. Fix typos in comments

  3. doc: Fix typo in pg_amcheck for term "schema"

  4. Remove unused global variable

  5. Fix incorrect function name reference

  6. Fix various typos and incorrect/outdated name references

  7. Fix some typos and some incorrectly duplicated words

  8. Fix various typos

  9. Improve GIN cost estimation

  10. Refactor LogicalTapeSet/LogicalTape interface.

  11. Refactor sharedfileset.c to separate out fileset implementation.

  12. Multirange datatypes

  13. Copy editing: fix a bunch of misspellings and poor wording.

  14. Implement operator class parameters

  15. Various improvements of skipping index scan during vacuum technics