Re: Add bms_offset_members() function for bitshifting Bitmapsets

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>

To: Greg Burd <greg@burd.me>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Chao Li <li.evan.chao@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2026-04-19T23:52:58Z

Lists: pgsql-hackers

Attachments

v3-0001-Introduce-bms_offset_members-function.patch (application/octet-stream) patch v3-0001

On Mon, 20 Apr 2026 at 07:22, Greg Burd <greg@burd.me> wrote:
> I applied, tested, and reviewed these changes.  Thanks for doing this, only a few small things jumped out.

Many thanks. I took all of those suggestions.

> SELECT test_bms_offset_members('(b 1)', -2147483648);

I made that one use member 0 instead of 1.  That'll mean "new_highest"
goes to INT_MIN rather than INT_MIN + 1.

David