Improve a few appendStringInfo calls new to v18

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>

To: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>

Date: 2025-04-10T03:51:15Z

Lists: pgsql-hackers

Attachments

v1-0001-Adjust-code-to-highlight-appendStringInfo-misusag.patch (application/octet-stream) patch v1-0001
v1-0002-Improve-various-appendStringInfo-calls-that-are-n.patch (application/octet-stream) patch v1-0002

Looks like v18 has grown a few appendStringInfo misusages, e.g. using
appendStringInfo() when no formatting is needed or just using format
"%s" instead of using appendStringInfoString().

I've attached a couple of patches. The 0001 is just my method for
finding these, not for commit. 0002 contains the fixes to commit.

Any objections to doing this soonish? Or in a few weeks?

David

Commits

Improve various new-to-v18 appendStringInfo calls
- 928394b664bc 18.0 landed
Fixup various StringInfo function usages
- 8461424fd717 17.0 cited