Re: Something seems weird inside tts_virtual_copyslot()
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-01T01:30:41Z
Lists: pgsql-hackers
Attachments
- ExecCopySlot_fix.patch (text/plain) patch
On Fri, 1 Dec 2023 at 13:14, Andres Freund <andres@anarazel.de> wrote: > So I think adding an assert to ExecCopySlot(), perhaps with a comment saying > that the restriction could be lifted with a bit of work, would be fine. Thanks for looking at this again. How about the attached? I wrote the comment you mentioned and also removed the Assert from tts_virtual_copyslot(). I also noted in the copyslot callback declaration that implementers can assume the number of attributes in the source and destination slots match. David
Commits
-
Verify that attribute counts match in ExecCopySlot
- d16a0c1e2e38 17.0 landed